search

purpleprotocol / mimalloc_rust

A Rust wrapper over Microsoft's MiMalloc memory allocator
MIT License
507 stars 43 forks source link

Replace cmake with cc #58

Closed Jake-Shadle closed 3 years ago

Jake-Shadle commented 3 years ago

This PR replaces the usage of cmake with just straight usage of cc. It replicates some of the logic in the cmakelists but is simplified since this crate only builds a static lib.

Resolves: #51

repi commented 3 years ago

Possible to get this merged in and publish a new release? Thanks!

repi commented 3 years ago

@octavonce any thoughts on getting this in? think it would be beneficial to most and we would be really happy getting rid of our fork

thomcc commented 3 years ago

Here's a (tested at least on my machines) patch containing all my suggestions that are actually worth doing in this PR: https://gist.github.com/thomcc/3a499f95c68ad8c8698f61235b1a0fa5