missing line ending in /release/build/libmimalloc-sys-xxxx/out/flag_check.c

purpleprotocol / mimalloc_rust

A Rust wrapper over Microsoft's MiMalloc memory allocator

MIT License

481 stars 42 forks source link

missing line ending in /release/build/libmimalloc-sys-xxxx/out/flag_check.c #90

Closed sorhawell closed 1 year ago

sorhawell commented 1 year ago

Hello wonderful people

I use your crate on a project called r-polars and it seems to be working great.

I tiny detail, the generated file /release/build/libmimalloc-sys-xxxx/out/flag_check.c is missing a line ending, which an upstream R-language repository package check unfortunately makes a fuzz about.

Is it possible one your side to add an extra line to that generated file?

Have a great day :)

sorhawell commented 1 year ago

Sorry the inconvenience.

I close this issue as in the end, it is to ask for trouble to suggest +50 rust crate maintainers to adhere to some arbitrary external ruleset. The risk of future issues is very high. Instead I just masked the rust dependency source file from the checker. It only needs to access final compiled binary.