changed a few thing to run smoothly under cygwin

purplesyringa / win-sudo

Add `sudo` command to Git Bash

MIT License

183 stars 55 forks source link

Closed riedel closed 6 years ago

riedel commented 6 years ago

I tried this great script under cygwin, ran in a few issues and fixed them quickly. Tested it in git bash. Seems to still work as expected.

set enviroment
get realpath to backend a bit more reliably under bash (when $0 is in path)
umask to hide a bit better towards other users (still not perfect and elevation can be easily highjacked by at least the same user)
moved help dialog for already elevated users

purplesyringa commented 6 years ago

Sorry for inactivity. Looks like this pr has some conflicts - can you please resolve them?

riedel commented 6 years ago

I merged and did a minor improvement

Quoting from the bash manual :

The command substitution $(cat file) can be replaced by the equivalent but faster $(< file).

purplesyringa commented 6 years ago

Thank you!