compressed a lot of code + automatic path (conclusive fix)

purplesyringa / win-sudo

Add `sudo` command to Git Bash

MIT License

183 stars 55 forks source link

compressed a lot of code + automatic path (conclusive fix) #23

Closed DemonixCraft-1 closed 6 years ago

DemonixCraft-1 commented 6 years ago

Finally compressed to one commit! Officially ready to be merged! Here's what I changed :

My accidental install.sh code input from the last fix
My absurdly large commit history. I compressed my fork down to one 1 commit! If you were to use PR #19 there would have been over 1000 objects to download.
My really unnecessary code compression for the echo commands in s/sudo
MINOR FIX : Changed the order of some commands in install.sh
HOTFIX : Revised ~/.bash_profile procedure and set url to original repo

DemonixCraft-1 commented 6 years ago

Okay here's what I changed in install.sh :

Changed url to match your repo
Set echo command to append to ~/.bashrc, ~/.bash_profile, and /etc/profile, each if existent. I could not change the echo command because tee is used to append to multiple files as we need here.

purplesyringa commented 6 years ago

I see, tee makes sense now.

DemonixCraft-1 commented 6 years ago

Do you want anything else changed?

DemonixCraft-1 commented 6 years ago

I also have another idea : we could make an alias for winpty so we don't have to write it out.

I was thinking something like ... alias wi='winpty' That way we would only have to type sudo wi [command_to_run], instead of sudo winpty [command_to_run]

But I'll put that in another PR I just want this one merged first so I don't have to worry about my broken repo at DemonixCraft and I can make a clean fork.

purplesyringa commented 6 years ago

Thank you.