search

purplesyringa / win-sudo

Add `sudo` command to Git Bash
MIT License
183 stars 55 forks source link

commands with sudo hang, su hangs #44

Closed michaelchanwork closed 1 year ago

michaelchanwork commented 4 years ago

After some fixes/handling of spaces in https://github.com/imachug/win-sudo/pull/43 (Which I can't test to have worked without the fixes, and currently believe the issue to be unrelated to aforementioned fixes)

Running su or sudo any command the terminal will simply hang indefinitely, though I am still able to ctrl+c out.

Windows 10, version 1909

$ bash --version
bash --version
GNU bash, version 4.4.23(1)-release (x86_64-pc-msys)
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
neveratdennys commented 2 years ago

I understand the issue with user name with spaces that is already fixed (which is true for my case), but I'm still having the same issue with su hanging after windows prompts for admin permissions. This is a really cool project regardless though, hopefully this can be fixed.

riedel commented 1 year ago

may this be the same problem as #36? It works for me inside mintty (using a pty) but not e.g. windows terminal (unsing the windows console)

riedel commented 1 year ago

Fixed in 5b2d65b4d38ee612598fa94980dacfa6e64b79c7 ?

neveratdennys commented 1 year ago

Just verified and looks like it's working for me now. Thanks!

purplesyringa commented 1 year ago

Thanks for the fix again!