push-based / ngx-fast-svg

📦 SVGs, fast and developer friendly in Angular
58 stars 5 forks source link

Demo not serving pre-rendered docs #44

Closed ChristopherPHolder closed 2 months ago

ChristopherPHolder commented 1 year ago

The live demo does not serve the pre-rendered version.

A potential cause is because it is redirecting in production:

Screenshot 2023-03-13 at 12 22 54

This means that when we try to access https://push-based.github.io/ngx-fast-svg/fast-svg?ls=distributed&list=1 We are redirected to from: https://push-based.github.io/ngx-fast-svg/fast-svg?ls=distributed&list=1 To: https://push-based.github.io/ngx-fast-svg/fast-svg/?ls=distributed&list=1

This means there is a unnecessary trailing slash with is directing to a page route which is not pre-rendered

/fast-svg/?ls=distributed&list=1 -> /fast-svg?ls=distributed&list=1

TODOS:

ChristopherPHolder commented 1 year ago

Potentially relevant:

https://dev.to/ayyash/fixing-the-trailing-slash-in-static-site-generation-107k

ChristopherPHolder commented 1 year ago

https://github.com/angular/angular/issues/16051#issuecomment-793005881