push-based / ngx-fast-svg

📦 SVGs, fast and developer friendly in Angular
54 stars 4 forks source link

Update to angular 18 #72

Closed Frosty1604 closed 1 month ago

Frosty1604 commented 3 months ago

Need to update the peer dependencies to support angular 18.

Error log:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @push-based/ngx-fast-svg@18.0.0
npm WARN Found: @angular/common@18.0.0
npm WARN node_modules/@angular/common
npm WARN   peer @angular/common@"^18.0.0 || ^19.0.0" from @angular/cdk@18.0.0
npm WARN   node_modules/@angular/cdk
npm WARN     @angular/cdk@"18.0.0" from the root project
npm WARN   7 more (@angular/forms, @angular/platform-browser, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @angular/common@"^17.0.0" from @push-based/ngx-fast-svg@18.0.0
npm WARN node_modules/@push-based/ngx-fast-svg
npm WARN   @push-based/ngx-fast-svg@"^18.0.0" from the root project
npm WARN 
npm WARN Conflicting peer dependency: @angular/common@17.3.10
npm WARN node_modules/@angular/common
npm WARN   peer @angular/common@"^17.0.0" from @push-based/ngx-fast-svg@18.0.0
npm WARN   node_modules/@push-based/ngx-fast-svg
npm WARN     @push-based/ngx-fast-svg@"^18.0.0" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @push-based/ngx-fast-svg@18.0.0
npm WARN Found: @angular/core@18.0.0
npm WARN node_modules/@angular/core
npm WARN   peer @angular/core@"18.0.0" from @angular/animations@18.0.0
npm WARN   node_modules/@angular/animations
npm WARN     peerOptional @angular/animations@"18.0.0" from @angular/platform-browser@18.0.0
npm WARN     node_modules/@angular/platform-browser
npm WARN     1 more (the root project)
npm WARN   11 more (@angular/cdk, @angular/common, @angular/compiler, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @angular/core@"^17.0.0" from @push-based/ngx-fast-svg@18.0.0
npm WARN node_modules/@push-based/ngx-fast-svg
npm WARN   @push-based/ngx-fast-svg@"^18.0.0" from the root project
npm WARN 
npm WARN Conflicting peer dependency: @angular/core@17.3.10
npm WARN node_modules/@angular/core
npm WARN   peer @angular/core@"^17.0.0" from @push-based/ngx-fast-svg@18.0.0
npm WARN   node_modules/@push-based/ngx-fast-svg
npm WARN     @push-based/ngx-fast-svg@"^18.0.0" from the root project
ChristopherPHolder commented 1 month ago

https://github.com/push-based/ngx-fast-svg/pull/73