search

push-based / ngx-fast-svg

📦 SVGs, fast and developer friendly in Angular
58 stars 5 forks source link

fix: upgrade dependencies for angular v18 compatibility #73

Closed jpsullivan closed 3 months ago

jpsullivan commented 4 months ago

This PR includes updates to the project that were performed after running nx migrate latest which brought all of the Angular dependencies to the latest and greatest.

Notably this also introduces support for those who are already using Angular 18 in their own projects, as the current version fails to install due to being capped at v17.

This does not bump the version in any way as I figured it'd be best to let the push-based team take care of that.

I tested the application by running npm run serve and can confirm that the library and demo app work as expected.

ChristopherPHolder commented 3 months ago

Thanks for the support its much appreciated.

We usually don't commit the migrations.json file in this repo.

The bumps are inferred from the git commit history so there is not need to update the project version directly-

jpsullivan commented 3 months ago

Ah I really should have caught that, sorry! Happy to help :)

I updated the PR to remove the inclusion of that file, along with some further peer dependency fixes.