search

push-based / nx-verdaccio

Enterprise E2E setup for Nx and Verdaccio
8 stars 0 forks source link

add suggestions #1

Closed getlarge closed 2 weeks ago

getlarge commented 1 month ago

My 2 cents, based on what I understand of the plugin. I still have to give it a spin!

nx-cloud[bot] commented 3 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 690166922c0cd73dfafe533c9955873ee3b9033d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target - [`nx code-pushup -- compare --before=/home/runner/work/nx-verdaccio-e2e-setup/nx-verdaccio-e2e-setup/.code-pushup/prev-report.json --after=/home/runner/work/nx-verdaccio-e2e-setup/nx-verdaccio-e2e-setup/.code-pushup/curr-report.json --persist.outputDir=.code-pushup --persist.filename=report --persist.format=json --persist.format=md`](https://cloud.nx.app/runs/i9dP7jdOpj?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 3 weeks ago

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 66a5372e6be89f99975602684e6307c5dfb34662 with source commit cddecb220d942fd09b4271102030e9fb1400abd0.

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 57 🟡 57 ↑ +0.3
👍 7 audits improved, 👎 1 audit regressed, 2 audits changed without impacting score ## 🛡️ Audits | 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change | | :-------------------- | :---------------------------------------- | :---------------: | :---------------: | :------------------------------------------------------------------------------: | | Nx Performance Checks | [Task Time] core-e2e:e2e | 🟨 33.84 s | 🟨 **32.58 s** | ![↓ −4 %](https://img.shields.io/badge/%E2%86%93%20%E2%88%924%E2%80%89%25-green) | | Nx Performance Checks | [Task Time] cli-e2e:e2e | 🟨 36.27 s | 🟨 **35.12 s** | ![↓ −3 %](https://img.shields.io/badge/%E2%86%93%20%E2%88%923%E2%80%89%25-green) | | Nx Performance Checks | [Task Time] cli-e2e:build-env-env-setup | 🟨 16.39 s | 🟨 **16.11 s** | ![↓ −2 %](https://img.shields.io/badge/%E2%86%93%20%E2%88%922%E2%80%89%25-green) | | Nx Performance Checks | [Task Time] models-e2e:e2e | 🟨 10.87 s | 🟨 **10.60 s** | ![↓ −2 %](https://img.shields.io/badge/%E2%86%93%20%E2%88%922%E2%80%89%25-green) | | Nx Performance Checks | [Task Time] cli:build | 🟩 5.59 s | 🟩 **5.53 s** | ![↓ −1 %](https://img.shields.io/badge/%E2%86%93%20%E2%88%921%E2%80%89%25-green) | | Nx Performance Checks | [Graph Time] task graph | 🟩 3.09 ms | 🟩 **3.34 ms** | ![↑ +8 %](https://img.shields.io/badge/%E2%86%91%20%2B8%E2%80%89%25-red) | | Nx Performance Checks | [Task Time] cli:unit-test | 🟩 986 ms | 🟩 **969 ms** | ![↓ −2 %](https://img.shields.io/badge/%E2%86%93%20%E2%88%922%E2%80%89%25-green) | | Nx Performance Checks | [Task Time] utils-e2e:e2e | 🟨 12.47 s | 🟨 **12.47 s** | ![↓ +0 %](https://img.shields.io/badge/%E2%86%93%20%2B0%E2%80%89%25-green) | | Nx Performance Checks | [Task Time] cli-e2e-original:original-e2e | 🟥 124.52 s | 🟥 **120.63 s** | ![↓ −3 %](https://img.shields.io/badge/%E2%86%93%20%E2%88%923%E2%80%89%25-gray) | | Nx Performance Checks | [Graph Time] project graph | 🟥 2794.08 ms | 🟥 **2795.92 ms** | ![↑ +0 %](https://img.shields.io/badge/%E2%86%91%20%2B0%E2%80%89%25-gray) | 5 other audits are unchanged.
getlarge commented 3 weeks ago

Are we merging this one? Or did you port all this code in other PRs?

BioPhoton commented 3 weeks ago

I was syncing this PR as good as possible. If i renamed or deleted a file I made sure it is reflected here. But I did not change your delivered code or anything.

I saw some changes are still here like cleaning up target deps or so.

Up to you how you want to go on here.

BioPhoton commented 2 weeks ago

Up dated again the PR after I moved over comments and reduced target config in #32 . Let's merge this now?

getlarge commented 2 weeks ago

Yes!