search

push-based / nx-verdaccio

Enterprise E2E setup for Nx and Verdaccio
8 stars 0 forks source link

refactor: use `runExecutor` from `@nx/devkit` instead of importing the executor implementation #6

Open getlarge opened 3 weeks ago

getlarge commented 3 weeks ago

There might be a small performance penalty, but it will ensure that options for a given configuration are loaded (it might be very useful in the future of this tool!) and validated.

BioPhoton commented 3 weeks ago

@getlarge Thanks for the input. I'm fine with the small perf panalty. Could you be so kind and point out where we should use it? Like file and line pls 🙏

getlarge commented 3 weeks ago

I can do it. Just wanted to be sure you are with that.

BioPhoton commented 3 weeks ago

It seems in this repo there is not a lot of discussion need :)

BioPhoton commented 2 weeks ago

Started implemented it and love it!!