Closed ChristopherPHolder closed 7 months ago
Date/Time: 2024-02-21 19:54
Step Name | Gather Mode | Performance | Accessibility | Best Practices | Seo | Pwa |
---|---|---|---|---|---|---|
๐งญ Navigate to coffee cart | navigation ๐ | 89 | 97 | 100 | 85 | 30 |
โ Select coffee | timespan | 11/11 | - | 7/7 | - | - |
โ Coffee selected | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐ Checkout order | timespan | 13/13 | - | 7/7 | - | - |
๐งพ Order checked out | snapshot | ร 3/3 | 17/18 | 5/5 | 7/9 | - |
๐ Submit order | timespan | 13/13 | - | 7/7 | - | - |
๐ง Order submitted | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐งญ Navigate to github | navigation ๐ | 99 | 96 | 100 | 85 | 30 |
Date/Time: 2024-02-21 19:54
Step Name | Gather Mode | Performance | Accessibility | Best Practices | Seo | Pwa |
---|---|---|---|---|---|---|
๐งญ Navigate to coffee cart | navigation ๐ | 92 | 97 | 100 | 85 | 30 |
โ Select coffee | timespan | 11/11 | - | 7/7 | - | - |
โ Coffee selected | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐ Checkout order | timespan | 13/13 | - | 7/7 | - | - |
๐งพ Order checked out | snapshot | ร 3/3 | 17/18 | 5/5 | 7/9 | - |
๐ Submit order | timespan | 13/13 | - | 7/7 | - | - |
๐ง Order submitted | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐งญ Navigate to github | navigation ๐ | 100 | 96 | 100 | 85 | 30 |
@Tlacenka
I am attempting to follow the advice you gave me in this comment, mocking part of the module being test to only test the expected "flow"
However I am encoutering an issue with the mocking:
jest.mock('./generate-lh-budgets', () => ({
...jest.requireActual('./generate-lh-budgets'), // This overrides all the mocks
budgetsFileExist: jest.fn(),
writeBudgetsFile: jest.fn(),
derivedBudgets: jest.fn(),
defaultBudgets: jest.fn(),
}));
Essentially i am not able to partially override the functions in the module. And by using ...jest.requireActual('./generate-lh-budgets') I am simply overriding all of them.
I would really appreciate some help ๐งญ
Conversation about what to mock was via video call ๐ฅ
Date/Time: 2024-02-23 12:24
Step Name | Gather Mode | Performance | Accessibility | Best Practices | Seo | Pwa |
---|---|---|---|---|---|---|
๐งญ Navigate to coffee cart | navigation ๐ | 96 | 97 | 100 | 85 | 30 |
โ Select coffee | timespan | 11/11 | - | 7/7 | - | - |
โ Coffee selected | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐ Checkout order | timespan | 13/13 | - | 7/7 | - | - |
๐งพ Order checked out | snapshot | ร 3/3 | 17/18 | 5/5 | 7/9 | - |
๐ Submit order | timespan | 13/13 | - | 7/7 | - | - |
๐ง Order submitted | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐งญ Navigate to github | navigation ๐ | 99 | 96 | 100 | 85 | 30 |
Date/Time: 2024-02-23 12:25
Step Name | Gather Mode | Performance | Accessibility | Best Practices | Seo | Pwa |
---|---|---|---|---|---|---|
๐งญ Navigate to coffee cart | navigation ๐ | 93 | 97 | 100 | 85 | 30 |
โ Select coffee | timespan | 11/11 | - | 7/7 | - | - |
โ Coffee selected | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐ Checkout order | timespan | 13/13 | - | 7/7 | - | - |
๐งพ Order checked out | snapshot | ร 3/3 | 17/18 | 5/5 | 7/9 | - |
๐ Submit order | timespan | 13/13 | - | 7/7 | - | - |
๐ง Order submitted | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐งญ Navigate to github | navigation ๐ | 100 | 96 | 100 | 85 | 30 |
Date/Time: 2024-02-23 12:29
Step Name | Gather Mode | Performance | Accessibility | Best Practices | Seo | Pwa |
---|---|---|---|---|---|---|
๐งญ Navigate to coffee cart | navigation ๐ | 92 | 97 | 100 | 85 | 30 |
โ Select coffee | timespan | 11/11 | - | 7/7 | - | - |
โ Coffee selected | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐ Checkout order | timespan | 13/13 | - | 7/7 | - | - |
๐งพ Order checked out | snapshot | ร 3/3 | 17/18 | 5/5 | 7/9 | - |
๐ Submit order | timespan | 13/13 | - | 7/7 | - | - |
๐ง Order submitted | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐งญ Navigate to github | navigation ๐ | 99 | 96 | 100 | 85 | 30 |
Date/Time: 2024-02-23 12:29
Step Name | Gather Mode | Performance | Accessibility | Best Practices | Seo | Pwa |
---|---|---|---|---|---|---|
๐งญ Navigate to coffee cart | navigation ๐ | 92 | 97 | 100 | 85 | 30 |
โ Select coffee | timespan | 11/11 | - | 7/7 | - | - |
โ Coffee selected | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐ Checkout order | timespan | 13/13 | - | 7/7 | - | - |
๐งพ Order checked out | snapshot | ร 3/3 | 17/18 | 5/5 | 7/9 | - |
๐ Submit order | timespan | 13/13 | - | 7/7 | - | - |
๐ง Order submitted | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐งญ Navigate to github | navigation ๐ | 99 | 96 | 100 | 85 | 30 |
Date/Time: 2024-02-23 18:32
Step Name | Gather Mode | Performance | Accessibility | Best Practices | Seo | Pwa |
---|---|---|---|---|---|---|
๐งญ Navigate to coffee cart | navigation ๐ | 96 | 97 | 100 | 85 | 30 |
โ Select coffee | timespan | 11/11 | - | 7/7 | - | - |
โ Coffee selected | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐ Checkout order | timespan | 13/13 | - | 7/7 | - | - |
๐งพ Order checked out | snapshot | ร 3/3 | 17/18 | 5/5 | 7/9 | - |
๐ Submit order | timespan | 13/13 | - | 7/7 | - | - |
๐ง Order submitted | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐งญ Navigate to github | navigation ๐ | 99 | 96 | 100 | 85 | 30 |
Date/Time: 2024-02-23 18:32
Step Name | Gather Mode | Performance | Accessibility | Best Practices | Seo | Pwa |
---|---|---|---|---|---|---|
๐งญ Navigate to coffee cart | navigation ๐ | 96 | 97 | 100 | 85 | 30 |
โ Select coffee | timespan | 11/11 | - | 7/7 | - | - |
โ Coffee selected | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐ Checkout order | timespan | 13/13 | - | 7/7 | - | - |
๐งพ Order checked out | snapshot | ร 3/3 | 17/18 | 5/5 | 7/9 | - |
๐ Submit order | timespan | 13/13 | - | 7/7 | - | - |
๐ง Order submitted | snapshot | ร 3/3 | 15/16 | 5/5 | 7/9 | - |
๐งญ Navigate to github | navigation ๐ | 99 | 96 | 100 | 85 | 30 |
TL;DR;
This PR makes generate-lh-budget unit test stable by decoupling them from the file system.
Test Fixed in this MR is not longer Flacky:
Was failing in target MR:
Description
It decouples the test from the file system by using mocks for the already existing file system helpers
To the couple the test from the file system we have simply mocked out the file helper returning the expected values instead of testing the files themselves.
It renames the test file name to include the new naming conversion for unit test.
It removes unnecessary code from the test, such as the example lighthouse report and uses a mock to ensure the derived report function is called.
It splits the functions in he generate-lh-budgets.ts file into smaller functions to make it easer to read and test.
It adds test case for when the budgets file already exists