Missing Notification Issue fixed

[abhishek-01k]

Pull Request Template

1592

Description

Some notifications were missing in the Inbox Channel Page. So here's what I did:

• When the Inbox is loaded so fetchNotifications is called and after that it increases the page number by 1.
• When the user reaches the bottom of the Inbox so loadNotifications is called and after the response is fetched it increments the page by 1.
• In this way, page is incremented by 1 and thus notifications are called in a proper manner.

No change in the Redux state management.

• Problem/Feature:

Type of Change

• [x] Bug fix

Checklist

• [x] Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • [ ] Quick PR label added
• [ ] Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • [ ] DO NOT Merge PR label added

Frontend Guidelines

• [ ] Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• [ ] No errors in the build terminal
• [ ] Engineer has tested the changes on their local environment
• [ ] Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

  

• For developers, you can test this in the networks tab where the page is not incremented by 1 but it increments by 2. So, notifications are missing.

• After: What's changed now

  

Additional Context

Review & Approvals

• [ ] Self-review completed
• [ ] Code review by at least one other engineer
• [ ] Documentation updates if applicable

[github-actions[bot]]

1. Missing closing curly brace after the if block in the loadNotifications function.
2. The variable bgUpdateLoading should be changed to setBgUpdateLoading in the fetchLatestNotifications function.
3. The page: 1, line in the fetchLatestNotifications function seems to be misplaced or incomplete.
4. The storeNotifications function is missing a closing curly brace.
5. Typo: setAllFilter should be changed to setFilteredNotifications in the fetchAllNotif function.
6. The fetchAllNotif function seems to have incomplete or misplaced code.
7. The comparison operator in the showWayPoint function should be !== instead of ===.
8. The logic inside the showWayPoint function seems incorrect. It might need to be revised based on the intended functionality.

After addressing the above points, the code review will be completed.

[github-actions[bot]]

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-06-04 07:54 UTC

[GeekyKartikey]

Looks good to me