Open corlard3y opened 1 month ago
In the file src/components/Faucets.tsx
:
Faucets
object. The objects inside are missing closing brackets.checkAlias
function is missing closing brackets.submitAlias
function is missing closing brackets and setLoading('Loading...');
should be moved outside setTimeout
block.checkAliasVerification
function is missing closing brackets.config
object, there is a typo Analaytics
, it should be corrected to Analytics
.config
object without proper key-value pairs.VerifyAlias
function is missing closing brackets at the end.In the file src/config/config-dev.js
:
In the file src/config/config-prod.js
:
config-dev.js
file, there are issues with objects inside objects missing closing brackets.In the file src/helpers/CaipHelper.ts
:
Eip155EnabledIds
should have Number
instead of number
.Kindly make the necessary corrections based on the observations mentioned above.
PR Preview Action v1.4.7
:---:
:rocket: Deployed preview to https://push-protocol.github.io/push-dapp/pr-preview/pr-1608/
on branch gh-pages
at 2024-06-11 12:32 UTC
In the file src/components/Faucets.tsx
, there are multiple syntax errors such as missing commas between object properties, incorrect formatting of object literals, and missing closing braces. Here are the corrections:
{
id: '97',
value: 'BNB',
title: 'BNB Faucet',
function: () => {},
link: 'https://testnet.bnbchain.org/faucet-smart',
},
{
id: '11155420',
value: 'Optimism',
title: 'Optimism Sepolia Faucet',
link: 'https://faucet.quicknode.com/optimism/sepolia',
},
{
id: '2442',
value: 'Polygon zkEVM',
title: 'Polygon zkEVM Bridge',
link: 'https://faucet.polygon.technology/',
},
{
id: '421614',
value: 'Arbitrum',
title: 'Arbitrum Testnet Faucet',
link: 'https://faucet.quicknode.com/arbitrum/sepolia',
},
{
id: '123',
value: 'Fuse',
title: 'Fuse Sparknet Faucet',
link: 'https://chaindrop.org/?chainid=123&token=0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
},
{
id: '111557560',
value: 'Cyber',
title: 'Cyber Faucet',
link: 'https://cyber-testnet.testnets.rollbridge.app/',
},
{
id: '84532',
value: 'Base Sepolia',
title: 'Base Sepolia Faucet',
link: 'https://www.alchemy.com/faucets/base-sepolia',
}
In the file src/config/config-dev.js
, there are missing curly braces in the objects defining Faucets information. Here are the corrected lines:
80002: {
label: 'Amoy MATIC',
url: 'https://faucet.polygon.technology/',
},
97: {
label: 'Testnet BNB',
url: 'https://testnet.bnbchain.org/faucet-smart',
},
11155420: {
label: 'Sepolia OpETH',
url: 'https://faucet.quicknode.com/optimism/sepolia',
},
2442: {
label: 'Polygon zkEVM ETH',
},
421614: {
label: 'Sepolia ArbETH',
url: 'https://faucet.quicknode.com/arbitrum/sepolia',
},
123: {
label: 'Fuse SPARK',
url: 'https://chaindrop.org/?chainid=123&token=0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
},
111557560: {
label: 'Cyber ETH',
url: 'https://cyber-testnet.testnets.rollbridge.app/',
},
84532: {
label: 'Base Sepolia',
url: 'https://www.alchemy.com/faucets/base-sepolia',
}
In the same file src/config/config-dev.js
, there are syntax errors in the aliasRPC
object. Here is the corrected format:
aliasRPC: {
80002: 'https://polygon-amoy.infura.io/v3/5524d420b29f4f7a8d8d2f582a0d43f7',
97: 'https://data-seed-prebsc-1-s1.binance.org:8545',
11155420: 'https://optimism-sepolia.infura.io/v3/5524d420b29f4f7a8d8d2f582a0d43f7',
2442: 'https://rpc.cardona.zkevm-rpc.com',
421614: 'https://arbitrum-sepolia.infura.io/v3/5524d420b29f4f7a8d8d2f582a0d43f7',
},
In the file src/helpers/CaipHelper.ts
, there is a missing closing brace at the end of the getCAIPObj
function. Here is the corrected line:
} // Add this closing brace
Additionally, there is an if
block in the convertAddrCaipToAddress
function that does not have a corresponding closing brace. Here is the corrected block:
if (caipArr.length == 3 && caipArr[0] == 'eip155') {
return caipArr[2];
}
throw new Error('Invalid CAIP Format');
After these corrections are made, the code should be free of syntax errors.
I have reviewed the provided code and found some issues and potential improvements:
"scripts"
section, there are multiple commands listed with syntax errors such as missing closing braces }
and misplaced characters <Button
, which need to be corrected.<path>
tag is using an incorrect closing tag syntax. It should be <path ... />
instead of <path ... "></>
.checkUserForAlias
function. The logic structure needs to be reviewed.{}
surrounding them.<Dropdown>
component may not be properly implemented. Ensure it is imported correctly.checkUserForEthAlias
function call, it's missing implementation.{}
.if
condition block in the checkAlias
function. Make sure it is properly closed.submitAlias
function.Eip155EnabledIds
array might have a typo with value 122
, which should be confirmed.Files like src/config/*.js
, src/helpers/UtilityHelper.ts
, src/hooks/useInactiveListener.ts
, src/redux/slices/adminSlice.js
, and src/structure/Header.tsx
were mentioned but not provided in the snippet for review.
Please address the above-mentioned issues in the respective files. Let me know if you need any further assistance.
Pull Request Template
1607
Description
CoinBase has invited us to deploy on Base chain, with the biggest incentive being the integration of Push Notifications in Coinbase Wallet. So we are basically just adding Base chain support, it’s just going to be a new chain like the others we have, from polygon, Arbitrum, cyber and the rest that have been added beforehand. So this is a new one called Base Chain - IIntegration of Push will enable native visibility of notifications from base ecosystem in coinbase wallet. So you can create channels, send notifications on this chain.
Type of Change
Checklist
Frontend Guidelines
Build & Testing
Screenshots/Video with Explanation
Before: Explain the previous behavior
After: What's changed now Added a channel on Base chain, and can send notifications from the chain as well![Screenshot 2024-06-07 at 16 48 33](https://github.com/push-protocol/push-dapp/assets/38462689/a6d0d639-4d9a-4414-8ebf-36d74369574b)
Additional Context
Review & Approvals
Notes