push-protocol / push-dapp

The Push Protocol Dapp
https://app.push.org
Other
42 stars 36 forks source link

DAPP-1619 nft success modal implemented #1625

Closed rohitmalhotra1420 closed 2 weeks ago

rohitmalhotra1420 commented 3 weeks ago

Pull Request Template

Ticket Number

Description

Type of Change

Checklist

Frontend Guidelines

Build & Testing

Screenshots/Video with Explanation

Additional Context

Review & Approvals

Notes

github-actions[bot] commented 3 weeks ago

In 'src/modules/claimGalxe/ClaimGalxeModule.tsx':

  1. Typo in importing 'ItemHV2' component: 'ItemHV2' should be 'ItemHV2V2'.
  2. Typo in importing 'SpanV2' component: 'SpanV2' should be 'SpanText'.
  3. Typo in setting button text in 'checkClaim' function: 'btnText' should be 'setSubmitbtnInfo({ btnText: 'Claim NFT', enabled: true, info: '', });'.
  4. Typo in the 'mintNft' function: 'const sendWithTxPromise = await nftRevealContract.mint(proof);' line is missing ending braces and semicolon.
  5. Closing brace missing at the end of the 'try' block in 'mintNft' function.
  6. Typo in 'setLoading' function calling is missing ending parentheses in the 'catch' block in 'mintNft' function.
  7. Missing closing brace '}' at the end of the component before 'export'.
  8. Typo in 'SpanText' component name: It should be 'SpanV2' instead of 'SpanText'.

In 'src/modules/claimGalxe/NFTSuccessModal.tsx':

  1. Typo in importing 'HoverableSVG' component: 'HoverableSVG' should be 'HoverableIcon'.
  2. Typo in 'Text' component: 'Text' should be 'BoxText'.
  3. Typo in 'Text' component: 'Text variant="bs-regular"' should be 'BoxText variant="bs-regular"'.
  4. Typo in 'Text' component: 'Text variant="h5-semibold"' should be 'BoxText variant="h5-semibold"'.

Please fix the mentioned issues in the files.

github-actions[bot] commented 3 weeks ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-06-18 09:18 UTC

github-actions[bot] commented 2 weeks ago

In the file src/hooks/useToast.tsx:

  1. In the LoaderMessage styled component, the closing tag is missing curly brace } which can cause parsing issues.
  2. In the Toast styled component, the closing tag is also missing curly brace }.

Other than the missing closing tags in the styled components, the code logic and structure seem to be correct.

In the files src/config/RecommendedChatsList.js and src/modules/claimGalxe/NFTSuccessModal.tsx, everything looks good.

Overall: All looks good.

abhishek-01k commented 2 weeks ago

the functionality works great