push-protocol / push-dapp

The Push Protocol Dapp
https://app.push.org
Other
45 stars 39 forks source link

DApp-1549 Dropdown/Menu component #1633

Closed corlard3y closed 3 months ago

corlard3y commented 3 months ago

Pull Request Template

1545

Description

Problem/Feature

Create a dropdown and menu package in the blocks folder and introduce these dropdown and menu items as a react component so that these could be reused in other component.

Figma: https://www.figma.com/design/FvJL0JWHlsVohsHTERB1Lh/Push-Design-Foundations-%5BFuture%5D?node-id=2663-23523&t=XRHuzgCLtQkYnb4h-1

Type of Change

Checklist

Frontend Guidelines

Build & Testing

Screenshots/Video with Explanation

Additional Context

Review & Approvals

Notes

github-actions[bot] commented 3 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://push-protocol.github.io/push-dapp/pr-preview/pr-1633/ on branch gh-pages at 2024-06-14 10:35 UTC

corlard3y commented 3 months ago

Added the basic flow of the dropdown and Menu, Pls lmk what changes can be added. Also, used hardcoding within the dropdown component so I will need your assistance/direction within the children(isOpen) param, and title ig @rohitmalhotra1420

rohitmalhotra1420 commented 3 months ago

@corlard3y the PR shows changes which are already merged and may have new changes done on top of them. Could you look into it and make sure the PR only has dropdown and menu related changes.