push-protocol / push-dapp

The Push Protocol Dapp
https://app.push.org
Other
42 stars 36 forks source link

DApp-1549 Dropdown/Menu component #1648

Closed corlard3y closed 2 days ago

corlard3y commented 2 weeks ago

Pull Request Template

1545

Description

Problem/Feature

Create a dropdown and menu package in the blocks folder and introduce these dropdown and menu items as a react component so that these could be reused in other component.

Figma: https://www.figma.com/design/FvJL0JWHlsVohsHTERB1Lh/Push-Design-Foundations-%5BFuture%5D?node-id=2663-23523&t=XRHuzgCLtQkYnb4h-1

Type of Change

Checklist

Frontend Guidelines

Build & Testing

Screenshots/Video with Explanation

Additional Context

Review & Approvals

Notes

github-actions[bot] commented 2 weeks ago

In the first file:

  1. Check if all imports are being used.
  2. In the StyledDropdown component, there is a comment using // instead of /* */.
  3. The logic in function getPlacementClass seems correct.
  4. Check if the DropdownProps definition is correct.

In the second file:

  1. Check if all imports are being used.
  2. In the StyledMenu component, padding is missing unit. It should be specified like padding: 8px 0;.
  3. Check if the MenuProps definition is correct.

In the third file:

  1. Check if all imports are being used.
  2. The StyledMenuItem component is using MenuItemProps instead of MenuItemComponentProps.
  3. In MenuItem component, the icon prop should be optional.
  4. Verify if MenuProps is correctly used in MenuItem.

If all the above points are handled, you can write 'All looks good.' after reviewing the changes.

corlard3y commented 2 weeks ago

Added the basic flow of the dropdown and Menu, Pls lmk what changes can be added. Also, used hardcoding within the dropdown component so I will need your assistance/direction within the children(isOpen) param, and title ig @rohitmalhotra1420

github-actions[bot] commented 2 weeks ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://push-protocol.github.io/push-dapp/pr-preview/pr-1648/ on branch gh-pages at 2024-06-17 10:47 UTC