push-protocol / push-dapp

The Push Protocol Dapp
https://app.push.org
Other
42 stars 36 forks source link

added lozenge and leaderboard tab #1653

Closed mishramonalisha76 closed 2 weeks ago

mishramonalisha76 commented 2 weeks ago

Pull Request Template

Ticket Number

Description

Type of Change

Checklist

Frontend Guidelines

Build & Testing

Screenshots/Video with Explanation

Demo link

Additional Context

Review & Approvals

Notes

github-actions[bot] commented 2 weeks ago

In the Star.tsx file:

  1. The width="inherit" attribute in the <svg> element should be replaced with an actual width value like 24px.
  2. In the FlattenSimpleInterpolation type definition in the Lozenge.constants.tsx, there is a typo in leading-trim and text-edge, which should be replaced with line-height and text-align respectively.

In the Rewards.constants.ts file:

  1. The rewardsTabsList array is missing proper array item syntax. It should be an array of objects with key-value pairs.

In the Rewards.tsx file:

  1. The locationArray split logic might not work as expected. Consider updating it to extract the correct tab information.

Other than the mentioned points, the code structure and logic seem fine.

Overall, after addressing the mentioned issues, the code looks good.

github-actions[bot] commented 2 weeks ago

All looks good.

github-actions[bot] commented 2 weeks ago

All looks good.

github-actions[bot] commented 2 weeks ago

All looks good.

github-actions[bot] commented 2 weeks ago

All looks good.

github-actions[bot] commented 2 weeks ago

All looks good.

github-actions[bot] commented 2 weeks ago

The code looks good.

github-actions[bot] commented 2 weeks ago

I found a few mistakes and issues in the provided code snippets:

  1. In the file src/App.tsx:

    • In the SpacesUIProvider component, there is a syntax error. The component is not closed properly after providing the theme prop.
  2. In the file src/blocks/lozenge/Lozenge.constants.tsx:

    • There is a duplicate parameter iconOnly?: boolean;. Remove one of these to avoid the duplication.
  3. In the same file src/blocks/lozenge/Lozenge.constants.tsx:

    • The comment note: - add medium small and large sizes is not properly formatted and might cause confusion.
  4. There seems to be missing content in the file src/blocks/lozenge/Lozenge.tsx. It is an empty file.

  5. In general, ensure consistent code formatting and commenting styles throughout the codebase.

After fixing the above issues, the code looks good. If you have any specific concerns or need further assistance, feel free to ask.

github-actions[bot] commented 2 weeks ago

All looks good.

github-actions[bot] commented 2 weeks ago

All looks good.

github-actions[bot] commented 2 weeks ago

All looks good.