API Integration of Rewards Activities

[abhishek-01k]

Pull Request Template

1655

Description

Added Mobile Viewport support and also dark mode for the Rewards Activities page.

Type of Change

• [ ] Bug fix
• [x] New feature
• [ ] Code refactor
• [ ] Documentation update
• [ ] Other (please describe):

Checklist

• [ ] Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • [ ] Quick PR label added
• [ ] Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • [ ] DO NOT Merge PR label added

Frontend Guidelines

• [x] Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• [ ] No errors in the build terminal
• [ ] Engineer has tested the changes on their local environment
• [ ] Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: No Dark mode and mobile support for the rewards page

• After: Dark mode feature added and mobile viewport is also done

Additional Context

Review & Approvals

• [ ] Self-review completed
• [ ] Code review by at least one other engineer
• [ ] Documentation updates if applicable

Notes

Things that are done:

• [x] Integrated APIs for the Activities Page.
• [x] Fetching API based on the user status of the activity.
• [x] Discord Flow is done.
• [x] User can Verify if they have joined discord or not.
• [x] Creating User ID is not done. Fetching details based on user id an d activityId
• [x] New Discord Flow is done which has only single button.
• [x] An ActionButton component is made as a template for new activity button.
• [x] Lozenge component is done based on expiryType

Things that are not done:

• [ ] Twitter Integration is not done because it is not implemented on the backend side.
• [ ] Discord Activity will have a Join Discord link near the subtitle of the discord.
• [ ] Error handling of the case when the user has not joined the discord. Right now, it gives a tooltip -> Failed to authenticate Discord membership.
• [ ] Error should be displayed below the Activity Component. Design will be given by Zee.

[github-actions[bot]]

All looks good.

[github-actions[bot]]

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://push-protocol.github.io/push-dapp/pr-preview/pr-1659/ on branch gh-pages at 2024-06-20 06:09 UTC

[github-actions[bot]]

There are a few things that need to be corrected or improved in the provided code snippets:

1. In the package.json file:

   • The version of "react" and "react-dom" should be updated to the latest stable version.
   • There is a mix of single and double quotes for the dependencies versions, it would be better to stick to a consistent style, either single or double quotes.

2. In the src/App.tsx file:

   • There is a commented out section of code that appears to be incomplete: // Provess App. It seems the comment should be 'Process App' and the rest of the code is missing.
   • The extendConsole function has a syntax error. Closing curly braces are missing for the console.enable function when enabled is false.

3. In the src/blocks/illustrations/components/RewardsCircle.tsx file:

   • The RewardsCircle component is missing type definitions for props. It should include types for IlliustrationWrappper and IllustrationProps.

4. In the src/modules/rewards/components/RewardsTabs.tsx file:

   • At the end of the file, there is an exported component line missing closing parenthesis. export { RewardsTabs }; should be export { RewardsTabs };.

5. In general, it is recommended to further analyze the code for any vulnerabilities or performance improvements.

After addressing the above points, the code can be reviewed again for further improvements.

[github-actions[bot]]

In the package.json file, there are multiple packages with versions specified. Everything looks good.

In the App.tsx file:

• There are some unused variables like IUseSpaceReturnValues, isSnapPage.
• There is an incomplete extendConsole function with a missing closing brace }.
• There is a typo in setcurrentTime, it should be setCurrentTime.
• The useEffect hook dependency array in the useEffect(() => { should include appConfig if it's being used inside the hook.

In the RewardsCircle.tsx file:

• The circle element in the SVG is missing the closing tag </circle>.

In the UnlockProfileWrapper.tsx file:

• There is a missing closing brace for the IntroContainerProps interface declaration.
• The else block inside the UnlockProfileWrapper component should return the JSX element.
• In the styled component Container, the comment tags are not properly closed.

Overall, some minor issues were found that need to be fixed. Once the fixes are applied, the code should be good to go.

[github-actions[bot]]

All looks good.

[github-actions[bot]]

All looks good.

[rohitmalhotra1420]

We will give function review on deploy preview after raising the PR towards main from rewardsV1. So merging this here.

cc: @abhishek-01k @corlard3y