push-protocol / push-dapp

The Push Protocol Dapp
https://app.push.org
Other
42 stars 36 forks source link

Rewards V1 #1664

Closed rohitmalhotra1420 closed 1 day ago

rohitmalhotra1420 commented 1 week ago

Pull Request Template

Ticket Number

Description

Type of Change

Checklist

Frontend Guidelines

Build & Testing

Screenshots/Video with Explanation

Additional Context

Review & Approvals

Notes

github-actions[bot] commented 1 week ago

All looks good.

github-actions[bot] commented 1 week ago

All looks good.

github-actions[bot] commented 1 week ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://push-protocol.github.io/push-dapp/pr-preview/pr-1664/ on branch gh-pages at 2024-07-03 15:02 UTC

rohitmalhotra1420 commented 1 week ago

@abhishek-01k

rohitmalhotra1420 commented 1 week ago

@corlard3y to fix the routes to

/points => dashboard tab /points/activity for => activity tab /points/leaderboard for => leaderboard tab

@corlard3y to discuss the approach told by Harsh regarding the user id with Ashish and do the relevant changes if required.

@abhishek-01k to fix the modal behaviour and on activity tab

corlard3y commented 1 week ago

Updated changes, fixed comments, added the hook to generate id, and also updated the routes, also added a loader to the top level page while first time users will see before they unlock profile and view the dashboard. Pls, lemme know any changes i missed, will ping you for doubts i had too @rohitmalhotra1420

abhishek-01k commented 1 week ago

In this commit, I have fixed some of the comments like the new ActivityButton method and some minor name changes and types of the component. Also, I have implemented the new inline error and also added the pending status.Dark mode is also made of this part.