DApp-1547 blocks/tabs - Githubissues

push-protocol / push-dapp

The Push Protocol Dapp

https://app.push.org

Other

42 stars 36 forks source link

DApp-1547 blocks/tabs #1679

Closed rohitmalhotra1420 closed 3 days ago

rohitmalhotra1420 commented 6 days ago

Pull Request Template

Ticket Number

1547

Description

Problem/Feature:
Implemented Tabs component inside blocks/tabs
Added two different variants for tabs fill and line
Implement both dark mode and light mode for both the variants.

Type of Change

[ ] Bug fix
[x] New feature
[ ] Code refactor
[ ] Documentation update
[ ] Other (please describe):

Checklist

[ ] Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
- [ ] Quick PR label added
[ ] Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
- [ ] DO NOT Merge PR label added

Frontend Guidelines

[x] Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

[x] No errors in the build terminal
[x] Engineer has tested the changes on their local environment
[ ] Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

Before: Explain the previous behavior
After: What's changed now

Additional Context

Review & Approvals

[x] Self-review completed
[ ] Code review by at least one other engineer
[ ] Documentation updates if applicable

Notes

github-actions[bot] commented 6 days ago

All looks good.

github-actions[bot] commented 6 days ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-07-01 09:39 UTC

github-actions[bot] commented 3 days ago

I have reviewed the provided code. Everything looks good.