push-protocol / push-dapp

The Push Protocol Dapp
https://app.push.org
Other
42 stars 36 forks source link

DApp-1639 update buttons ui and support dark mode #1681

Closed kalashshah closed 3 days ago

kalashshah commented 3 days ago

Pull Request Template

Ticket Number

Description

Type of Change

Checklist

Frontend Guidelines

Build & Testing

Screenshots/Video with Explanation

image image

Additional Context

Review & Approvals

Notes

github-actions[bot] commented 3 days ago

In the Button.constants.ts file:

In the Button.tsx file:

Overall, the code structure looks fine but there are some missing braces and undefined CSS variables in the provided code snippets.

All looks good.

github-actions[bot] commented 3 days ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-07-01 15:02 UTC

kalashshah commented 3 days ago

image @kalashshah can you confirm this from Zee oncee, the recommended chat colour seems different than the one in figma

Zee mentioned that the colors were incorrect anyway, it is fine for now but needs to be changed to the correct colors later

mishramonalisha76 commented 3 days ago

image @kalashshah can you confirm this from Zee oncee, the recommended chat colour seems different than the one in figma

Zee mentioned that the colors were incorrect anyway, it is fine for now but needs to be changed to the correct colors later

@kalashshah lets create an issue for the same

kalashshah commented 3 days ago

Yeah already created: https://github.com/push-protocol/push-sdk/issues/1373