Closed kalashshah closed 3 days ago
In the Button.constants.ts
file:
case 'primary'
block is missing closing braces }
for the background-color
properties under the :active
and :focus-visible
states.case 'secondary'
block is missing opening braces {
before the background-color: ${getBlocksColor(
property within the case block.case
blocks like 'tertiary'
, 'danger'
, 'dangerSecondary'
, and 'outline'
. Missing opening braces {
and closing braces }
in various places.In the Button.tsx
file:
StyledButton
component, there is a reference to --r10
which is not defined in the provided CSS.Button
component is missing a closing brace }
after the return statement inside the forwardRef function.Overall, the code structure looks fine but there are some missing braces and undefined CSS variables in the provided code snippets.
All looks good.
PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-07-01 15:02 UTC
@kalashshah can you confirm this from Zee oncee, the recommended chat colour seems different than the one in figma
Zee mentioned that the colors were incorrect anyway, it is fine for now but needs to be changed to the correct colors later
@kalashshah can you confirm this from Zee oncee, the recommended chat colour seems different than the one in figma
Zee mentioned that the colors were incorrect anyway, it is fine for now but needs to be changed to the correct colors later
@kalashshah lets create an issue for the same
Yeah already created: https://github.com/push-protocol/push-sdk/issues/1373
Pull Request Template
Ticket Number
Description
Type of Change
Checklist
Frontend Guidelines
Build & Testing
Screenshots/Video with Explanation
Additional Context
Review & Approvals
Notes