push-protocol / push-dapp

The Push Protocol Dapp
https://app.push.org
Other
42 stars 37 forks source link

Continuous loading state of the profile modal issue fixed #1697

Closed abhishek-01k closed 1 week ago

abhishek-01k commented 1 week ago

Pull Request Template

Ticket Number

No ticket created

Description

Continuous loading state of the profile modal is fixed. When the wallet is connected and PGP keys are present so the modal goes into loading state so fixed that. Now, Push user is initialised at that point and modal gets closed.

Type of Change

Checklist

Frontend Guidelines

Build & Testing

Screenshots/Video with Explanation

Additional Context

Review & Approvals

Notes

github-actions[bot] commented 1 week ago

All looks good.

github-actions[bot] commented 1 week ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-07-04 12:23 UTC

github-actions[bot] commented 1 week ago

In the file src/components/chat/unlockProfile/UnlockProfile.tsx:

  1. There is a typo in the import statement for 'ItemVV2'. It should be 'ItemV2'.
  2. The 'body' property in the 'PROFILESTATE' enum is missing a closing single quote.
  3. The 'handleRememberMeChange' function is missing a closing curly brace '}'.
  4. The 'useEffect' hook is missing a closing curly brace '}'.
  5. The 'handleChatprofileUnlock' function is missing a closing curly brace '}'.
  6. The 'useEffect' hook is missing a dependency array and the related closing parenthesis.
  7. There is a typo in the 'ItemHV2' component, the prop should be 'flexDirection' instead of 'flexDirections'.
  8. The styling prop 'fontSize' is missing a property in the 'SpanV2' component.
  9. The 'useEffect' hook is missing a closing curly brace '}'.
  10. The 'ProfileState' type in the 'useEffect' hook is missing a closing parenthesis and curly brace ')}'.

In the file src/modules/rewards/components/RewardsActivitiesListItem.tsx:

  1. The if condition for rendering the Description component is missing a closing parenthesis and a closing curly brace ')}'.
  2. The closing div tag '' is missing in the file.
  3. There is a typo in the prop 'lp' in the 'padding' property of the Box component, it should be 'pl'.
  4. The 'gap' property in the Box component is missing a value.
  5. The 'gap' property in the Box component is missing a value.

All looks good.

github-actions[bot] commented 1 week ago

In the UnlockProfile.tsx file:

  1. There is a missing closing '}' after the enum PROFILESTATE.
  2. In the handleRememberMeChange function, there is a missing closing '}' after the setRememberMe function.
  3. In the useEffect hook, there is a missing closing '}' after the if block.
  4. Inside the handleChatprofileUnlock function, there is a missing closing '}' after the setRememberMe function.
  5. Inside the useEffect hook, there is a missing closing '}' after the initializePushSDK function.

In the DashboardSectionPoints.tsx file:

  1. Inside the Text component, there is a meaningless '0'.
  2. The Text component inside the points check should have a 'variant' and 'color' prop.
  3. The rank display logic is not correct. It should be placed inside a Text component.

In the RewardsActivitiesListItem.tsx file:

  1. There is a missing closing } after the Skeleton component.
  2. The remaining Text component after the Skeleton should be inside parentheses.
  3. The conditional rendering for the rank logic is incorrect. It should be placed inside a Text component.

In the Header.tsx file:

  1. There is a missing closing '}' after the last Box component.
  2. The RewardsHeaderLink component is not closed properly, it should have a closing tag .
  3. The function Header is not closed properly, it should have a closing '}'.

Overall there are multiple missing closing braces '}' and incorrect placements of components in the provided files. It seems that the code structure needs some corrections to ensure proper functionality.