DApp-1708-1709 new theme support in blocks and their usage - Githubissues

push-protocol / push-dapp

The Push Protocol Dapp

https://app.push.org

Other

45 stars 39 forks source link

DApp-1708-1709 new theme support in blocks and their usage #1753

Closed rohitmalhotra1420 closed 2 months ago

rohitmalhotra1420 commented 2 months ago

Pull Request Template

Ticket Number

1708
1709

Description

Problem/Feature:
Fixed the semantics.
Added support for semantics in the older blocks components.
Fixed older blocks components to support new css variables.
Fixed the usage of blocks components throughout application.

Type of Change

[ ] Bug fix
[x] New feature
[x] Code refactor
[ ] Documentation update
[ ] Other (please describe):

Checklist

[ ] Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
- [ ] Quick PR label added
[ ] Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
- [ ] DO NOT Merge PR label added

Frontend Guidelines

[ ] Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

[ ] No errors in the build terminal
[ ] Engineer has tested the changes on their local environment
[ ] Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

Before: Explain the previous behavior
After: What's changed now

Additional Context

Review & Approvals

[ ] Self-review completed
[ ] Code review by at least one other engineer
[ ] Documentation updates if applicable

Notes

github-actions[bot] commented 2 months ago

All looks good.

github-actions[bot] commented 2 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-07-19 11:32 UTC