search

push-protocol / push-restapi-dart

BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

Issue with using the SDK with the ERC4337 wallets, HSM, and WalletConnect #56

Closed AyushBherwani1998 closed 1 year ago

AyushBherwani1998 commented 1 year ago

Description

The way the SDK is architectured, it always assumes that the wallet that will be used for PUSH Chat/GroupChat will be always be an EOA with application always having access to wallet keystore. The SDK is not compatible with 4337 wallets, HSM and WalletConnect since in any of the above case we might have access to keystore.

AyushBherwani1998 commented 1 year ago

Closing, because we can customize signer by extending Signer our own signer for the use cases apart from ones where we have keystore available.