push-protocol / push-sdk-starter-kit

Other
3 stars 7 forks source link

Problem with GENERATE_SOURCEMAP=false #2

Open scguaquetam opened 1 year ago

scguaquetam commented 1 year ago

Good day !! Trying to follow the official docs for getting started with (https://docs.push.org/developers/developer-tooling/push-sdk/epns-sdk-starter-kit). In the repository package.json =====> "scripts": { "start": "GENERATESOURCEMAP=false react-scripts start", "build": "react-scripts build", "test": "react-scripts test", "eject": "react-scripts eject" }, Im using Yarn Version 1.22.19, and when use command yarn start_, as the guide says, it shows the next problem:

yarn run v1.22.19 $ GENERATE_SOURCEMAP=false react-scripts start 'GENERATE_SOURCEMAP' is not recognized as an internal or external command, operable program or batch file. error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

If I take out _GENERATESOURCEMAP=false from the package.json file, it allows now to run the demo and issue gets solved, looks like a version issue.

vijoin commented 1 year ago

@sheva323 I have the same yarn version installed and it ran perfectly. Can you provide which OS your using? I'm using Ubuntu 22.10

scguaquetam commented 1 year ago

Hello @vijoin, this problem happened using windows 10.

vijoin commented 1 year ago

Yes @sheva323 the problem is you're using windows. As you can see here: https://stackoverflow.com/questions/57839600/pass-environment-variable-from-command-line-to-yarn .... in the shortcut start": "GENERATE_SOURCEMAP=false react-scripts start .... the part GENERATE_SOURCEMAP=false is a environment variable assignment that works only in Unix-like systems like Ubuntu or MacOS.

A workaround for windows users could be changing the shortcut to start": "GENERATE_SOURCEMAP=false && react-scripts start (not tested yet)

The other thing that could be done is adding a comment in the docs about this problem or that the tutorial is meant to be executed in a Unix-like platform

scguaquetam commented 1 year ago

Yes, I think the best option is to add the note on the docs for Unix-like users.