push-protocol / push-sdk

Push SDK is a growing Monorepo of packages that provide solutions for a wide range of development tasks one might come across while building on top of Push protocol. It is a Javascript-based group of packages that enables easy usage of imperative communication tools for Web3
Other
75 stars 52 forks source link

Add erc1155 to token gating group conditions #1381

Closed kalashshah closed 3 months ago

kalashshah commented 4 months ago

Fixes Issue

Closes #1380

Changes proposed

Check List (Check all the applicable boxes)

github-actions[bot] commented 4 months ago

In the package.json file:

  1. The "peerDependencies" should be closed with a closing brace '}' after the last dependency.
  2. The "devDependencies" section should be closed with a closing brace '}' after the last dev dependency.
  3. There is a missing comma after "styled-components": "^6.0.8".
  4. The version of react is specified as ">=16.8.0" which should be without the greater than sign: "16.8.0".

For the AddCriteria.tsx file:

  1. The import statements for helper functions should be corrected with commas separating each function.
  2. There is a missing closing curly brace '}' after the error handling block.
  3. There seems to be an issue with the structure and logic of setting different category values in the dropdowns.

Overall, there seem to be multiple issues related to syntax, organization, and logic that need addressing.

Please correct these issues and re-run the code for further review.

abhishek-01k commented 4 months ago
Screenshot 2024-08-01 at 5 13 37 PM

Is this UI correct?

kalashshah commented 4 months ago
Screenshot 2024-08-01 at 5 13 37 PM

Is this UI correct?

https://www.figma.com/design/FvJL0JWHlsVohsHTERB1Lh/Push-Design-Foundations-%5BFuture%5D?node-id=5862-32769&t=6TJkYbnklLVUd76p-1

abhishek-01k commented 4 months ago

LGTM 👍🏻