search

pushbits / server

A simple server for push notifications via Matrix (and a minimalistic alternative to Pushover and Gotify) 🚀📯
https://www.pushbits.io
ISC License
305 stars 18 forks source link

Add support for PostgreSQL #13

Closed eikendev closed 1 year ago

eikendev commented 4 years ago

PostgreSQL is a great database, but I haven't found time to implement this yet.

rafaelespinoza commented 1 year ago

Hello, is this support still wanted? If so, I'd be interested in contributing.

eikendev commented 1 year ago

Hi @rafaelespinoza, sorry for the delayed response. Happy if you give it a try!

rafaelespinoza commented 1 year ago

Okay great. I have something basic set up in my topic branch over at my fork: https://github.com/rafaelespinoza/pushbits_server/tree/feat-postgres

Locally, I've run tests, and they work. Though the tests only work on sqlite3. Was there any automated testing done for MySQL?

eikendev commented 1 year ago

Great! Can I ask you to open a PR so I can review?

Of course, at some point we need to lay the foundation to perform integration tests. But for now, as long as we are still in alpha, I think it's currently ok to skip integration tests.

rafaelespinoza commented 1 year ago

For sure, here's the PR https://github.com/pushbits/server/pull/67

eikendev commented 1 year ago

Closed in #67.