search

pushbits / server

A simple server for push notifications via Matrix (and a minimalistic alternative to Pushover and Gotify) 🚀📯
https://www.pushbits.io
ISC License
314 stars 18 forks source link

Add delete endpoint for messages #30

Closed CubicrootXYZ closed 3 years ago

CubicrootXYZ commented 3 years ago

Added a delete endpoint for messages. It is using the matrix event id as identifier.

If you delete a message the following will happen:

Unbenannt

I choose this way as that would offer a nice opportunity for alerting - the message will not be silently removed, Matrix will inform you about the deletion - that could be the resolving of an alert.

Another small detailed I changed: I added an "error to HTTP status code" mapping to the successOrAbort method. My thoughts about that are that we do not need to handle that in every handler separately and that it will encourage us to use predefined errors what will make the code more consistence.

Please don't feel presured about the next pr I opened - definetely no need to rush here, just lots of spare time on my site.

eikendev commented 3 years ago

Hey @CubicrootXYZ, this looks great! I'll schedule a review on my side for Thursday.

eikendev commented 3 years ago

One design question: Why do we send the deleted text in the response message? Wasn't sure if introducing duplication here helps clarity.

CubicrootXYZ commented 3 years ago

One design question: Why do we send the deleted text in the response message? Wasn't sure if introducing duplication here helps clarity.

That's how "replies" work in matrix. They always cite the original content. The exact format is defined in the matrix docs