pushbits / server

A simple server for push notifications via Matrix (and a minimalistic alternative to Pushover and Gotify) 🚀📯
https://www.pushbits.io
ISC License
305 stars 18 forks source link

Switch to mautrix-go #38

Closed CubicrootXYZ closed 2 years ago

CubicrootXYZ commented 2 years ago

In order to get more features (e.g. encryption #24) switch from the default matrix go library to mautrix-go.

CubicrootXYZ commented 2 years ago

Code wise the work is done, needs testing now.

CubicrootXYZ commented 2 years ago

Wow, this looks a lot simpler that I had imagined; good job. What kind of testing do you mean, function tests or manual testing?

Manual testing if everything still works, did not do that yesterday but did it now.

CubicrootXYZ commented 2 years ago

matrix.org seems to have some trouble currently, will try testing it later again.

CubicrootXYZ commented 2 years ago

Digging deeper I think the issue is that the session from the bot is not verified and therefore the clients from other users will ignore any event sent to them.

CubicrootXYZ commented 2 years ago

Everything working fine - somehow my bot got on the ignored list, my bad. Tested it and it is working just fine.

eikendev commented 2 years ago

Thanks for rebasing, I'll take a look this week!

eikendev commented 2 years ago

Removed the link to #24 as it seems more work would be required for E2E. Is this ready to be merged from your PoV?

CubicrootXYZ commented 2 years ago

Removed the link to #24 as it seems more work would be required for E2E. Is this ready to be merged from your PoV?

yes, it is.