pushbits / server

A simple server for push notifications via Matrix (and a minimalistic alternative to Pushover and Gotify) 🚀📯
https://www.pushbits.io
ISC License
314 stars 18 forks source link

Latest Docker image is broken #51

Closed CiTuX closed 2 years ago

CiTuX commented 2 years ago

Hi

Since version 0.8.4 the Docker image doesn't seem to work anymore:

2022/04/15 10:04:01 Version not set
panic: Version not set

goroutine 1 [running]:
log.Panic({0xc00039ff50?, 0x446531?, 0xc000088710?})
        /usr/local/go/src/log/log.go:385 +0x65
main.main()
        /build/cmd/pushbits/main.go:48 +0x7a

I'm guessing it's reletated to these changes:

Maybe the git describe --tags command in the Makefile isn't working as expected during the build of the image?

eikendev commented 2 years ago

Hi, thanks for raising this issue.

Seems related to some recent work on the build pipeline I've done. The git command fails because the git folder is not added to the Docker build environment.

I'll try work out a fix tomorrow, on Monday latest. Please fall back to the previous version until then.

eikendev commented 2 years ago

Hi @CiTuX, this issue should be fixed as of v0.8.5. Please let us know should the issue persist.

CiTuX commented 2 years ago

Hi @eikendev, I can confirm that the issue is fixed, thx 👍🏽