pusher-community / pusher-websocket-ruby

Ruby WebSocket client for Pusher Channels
https://pusher.com/channels
MIT License
61 stars 61 forks source link

Removed openssl-nonblock, as it is no longer necessary #16

Closed Aaron1011 closed 11 years ago

Aaron1011 commented 11 years ago

It has been stated here by the gem's author that openssl-nonblock is no longer necessary with any supported version of Ruby.

dbussink commented 11 years ago

openssl-nonblock is also not necessary for 1.8.7, only for 1.8.6 and <= 1.9.2

Aaron1011 commented 11 years ago

@logankoester: Can you please take a look at this? My PR at https://github.com/travis-ci/travis/pull/64 needs this to be merged, as openssl-nonblock fails to build on Rubinius.

adamyeats-zz commented 11 years ago

@logankoester, this was a small change so I merged this commit myself so our friends at TravisCI can continue with their project. Hope you don't mind. :)

Aaron1011 commented 11 years ago

@adamyeats, the newest version of this gem needs to be released to RubyGems, so we can add it to the gemspec at Travis CI.

adamyeats-zz commented 11 years ago

@Aaron1011: Before I release to RubyGems, I need to look into why the build is still failing on rbx-19mode (and also jruby-18mode).

Here's the stack trace from the failing build if you can tell what's going on here:

Installing linecache19 (0.5.12) 
Gem::Installer::ExtensionBuildError: ERROR: Failed to build gem native extension.
    /home/travis/.rvm/rubies/rubinius-2.0.0-weekly20130723-d19/bin/rbx extconf.rb 
checking for vm_core.h... no
checking for vm_core.h... no
Requesting http://ftp.ruby-lang.org/pub/ruby/1.9/ruby-1.9.3-p0.tar.gz
Downloading http://ftp.ruby-lang.org/pub/ruby/1.9/ruby-1.9.3-p0.tar.gz
checking for vm_core.h... no
Makefile creation failed
*************************************************************
  NOTE: For Ruby 1.9 installation instructions, please see:
     http://wiki.github.com/mark-moseley/ruby-debug
*************************************************************
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of
necessary libraries and/or headers.  Check the mkmf.log file for more
details.  You may need configuration options.
Provided configuration options:
    --with-opt-dir
    --without-opt-dir
    --with-opt-include
    --without-opt-include=${opt-dir}/include
    --with-opt-lib
    --without-opt-lib=${opt-dir}/lib
    --with-make-prog
    --without-make-prog
    --srcdir=.
    --curdir
    --ruby=/home/travis/.rvm/rubies/rubinius-2.0.0-weekly20130723-d19/bin/rbx
    --with-ruby-dir
    --without-ruby-dir
    --with-ruby-include
    --without-ruby-include=${ruby-dir}/include
    --with-ruby-lib
    --without-ruby-lib=${ruby-dir}/lib
Gem files will remain installed in /home/travis/.rvm/gems/rubinius-2.0.0-weekly20130723-d19/gems/linecache19-0.5.12 for inspection.
Results logged to /home/travis/.rvm/gems/rubinius-2.0.0-weekly20130723-d19/gems/linecache19-0.5.12/ext/trace_nums/gem_make.out
An error occurred while installing linecache19 (0.5.12), and Bundler cannot
continue.
Make sure that `gem install linecache19 -v '0.5.12'` succeeds before bundling.
The command "bundle install --without debug" failed. Retrying, 2 of 3.
Fetching gem metadata from https://www.rubygems.org/.........
Fetching gem metadata from https://www.rubygems.org/..
Resolving dependencies...
Using rake (10.1.0) 
Using archive-tar-minitar (0.5.2) 
Using bacon (1.2.0) 
Using columnize (0.3.6) 
Using ruby_core_source (0.1.5) 
Installing linecache19 (0.5.12) 
Gem::Installer::ExtensionBuildError: ERROR: Failed to build gem native extension.
    /home/travis/.rvm/rubies/rubinius-2.0.0-weekly20130723-d19/bin/rbx extconf.rb 
checking for vm_core.h... no
checking for vm_core.h... no
Requesting http://ftp.ruby-lang.org/pub/ruby/1.9/ruby-1.9.3-p0.tar.gz
Downloading http://ftp.ruby-lang.org/pub/ruby/1.9/ruby-1.9.3-p0.tar.gz
checking for vm_core.h... no
Makefile creation failed
*************************************************************
  NOTE: For Ruby 1.9 installation instructions, please see:
     http://wiki.github.com/mark-moseley/ruby-debug
*************************************************************
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of
necessary libraries and/or headers.  Check the mkmf.log file for more
details.  You may need configuration options.
Provided configuration options:
    --with-opt-dir
    --without-opt-dir
    --with-opt-include
    --without-opt-include=${opt-dir}/include
    --with-opt-lib
    --without-opt-lib=${opt-dir}/lib
    --with-make-prog
    --without-make-prog
    --srcdir=.
    --curdir
    --ruby=/home/travis/.rvm/rubies/rubinius-2.0.0-weekly20130723-d19/bin/rbx
    --with-ruby-dir
    --without-ruby-dir
    --with-ruby-include
    --without-ruby-include=${ruby-dir}/include
    --with-ruby-lib
    --without-ruby-lib=${ruby-dir}/lib
Gem files will remain installed in /home/travis/.rvm/gems/rubinius-2.0.0-weekly20130723-d19/gems/linecache19-0.5.12 for inspection.
Results logged to /home/travis/.rvm/gems/rubinius-2.0.0-weekly20130723-d19/gems/linecache19-0.5.12/ext/trace_nums/gem_make.out
An error occurred while installing linecache19 (0.5.12), and Bundler cannot
continue.
Make sure that `gem install linecache19 -v '0.5.12'` succeeds before bundling.
The command "bundle install --without debug" failed. Retrying, 3 of 3.
Fetching gem metadata from https://www.rubygems.org/.........
Fetching gem metadata from https://www.rubygems.org/..
Resolving dependencies...
Using rake (10.1.0) 
Using archive-tar-minitar (0.5.2) 
Using bacon (1.2.0) 
Using columnize (0.3.6) 
Using ruby_core_source (0.1.5) 
Installing linecache19 (0.5.12) 
Gem::Installer::ExtensionBuildError: ERROR: Failed to build gem native extension.
    /home/travis/.rvm/rubies/rubinius-2.0.0-weekly20130723-d19/bin/rbx extconf.rb 
checking for vm_core.h... no
checking for vm_core.h... no
Requesting http://ftp.ruby-lang.org/pub/ruby/1.9/ruby-1.9.3-p0.tar.gz
Downloading http://ftp.ruby-lang.org/pub/ruby/1.9/ruby-1.9.3-p0.tar.gz
checking for vm_core.h... no
Makefile creation failed
*************************************************************
  NOTE: For Ruby 1.9 installation instructions, please see:
     http://wiki.github.com/mark-moseley/ruby-debug
*************************************************************
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of
necessary libraries and/or headers.  Check the mkmf.log file for more
details.  You may need configuration options.
Provided configuration options:
    --with-opt-dir
    --without-opt-dir
    --with-opt-include
    --without-opt-include=${opt-dir}/include
    --with-opt-lib
    --without-opt-lib=${opt-dir}/lib
    --with-make-prog
    --without-make-prog
    --srcdir=.
    --curdir
    --ruby=/home/travis/.rvm/rubies/rubinius-2.0.0-weekly20130723-d19/bin/rbx
    --with-ruby-dir
    --without-ruby-dir
    --with-ruby-include
    --without-ruby-include=${ruby-dir}/include
    --with-ruby-lib
    --without-ruby-lib=${ruby-dir}/lib
Gem files will remain installed in /home/travis/.rvm/gems/rubinius-2.0.0-weekly20130723-d19/gems/linecache19-0.5.12 for inspection.
Results logged to /home/travis/.rvm/gems/rubinius-2.0.0-weekly20130723-d19/gems/linecache19-0.5.12/ext/trace_nums/gem_make.out
An error occurred while installing linecache19 (0.5.12), and Bundler cannot
continue.
Make sure that `gem install linecache19 -v '0.5.12'` succeeds before bundling.
The command "bundle install --without debug" failed and exited with 5 during install.
dbussink commented 11 years ago

ruby-debug doesn't work on Rubinius because it accesses internals of the virtual machine. Rubinius has a built in debugger, so ruby-debug is not needed there.

dbussink commented 11 years ago

You probably want to use :mri_19 as the platform for ruby_debug and not :ruby_19.

Aaron1011 commented 11 years ago

The problem is that when the PR got merged, my version of the Gemfile got left out. You want to put ruby-debug into group :debug.

Aaron1011 commented 11 years ago

The .travis.yml is set up to exclude it from installation on Travis CI, as no one is doing any debugging when the tests are running.

Aaron1011 commented 11 years ago

I've added in json as a dependency for Ruby 18 in PR https://github.com/pusher/pusher-ruby-client/pull/18.