search

pusher-community / pusher-websocket-ruby

Ruby WebSocket client for Pusher Channels
https://pusher.com/channels
MIT License
61 stars 61 forks source link

Allow certificate to be changed #21

Closed Aaron1011 closed 11 years ago

pat commented 11 years ago

@Aaron1011 is there a particular reason for this change? I'm getting errors with certs when talking to Pusher through this library, albeit not consistently, and I'm wondering if it's related to why you've submitted this pull request.

Aaron1011 commented 11 years ago

@pat: This is needed to resolve issue https://github.com/travis-ci/travis/issues/86

rkh commented 11 years ago

Any news on this?

mloughran commented 11 years ago

I'm happy to merge this if it's a quick win - but do we think it's really necessary to include the root certs anyway? /cc @rkh @pat

pat commented 11 years ago

@mloughran my issue was unrelated to this patch, and has been resolved.

From what I understand, this is purely related to ease of testing, especially with Travis (which is probably why @rkh is keen to see it merged). Whether you include the certs is your call though :)

rkh commented 11 years ago

We need this change to work with our on premises setups. However, given other issues (see #13), leaking global state and the code not being very modular I am actually edging close to either implement our own client or switching our streaming over to server sent events. I'm not keen on implementing either, as this might involve quite some work and maintenance, but both the code and how issues are being handled here does not seem like maintaining a ruby client is a priority at pusher, either.

mloughran commented 11 years ago

@pat @rkh would it help if you guys were given commit rights to this repo and to release new gem versions? As you say @rkh the code is rather a mess at present, but it's actually a very small library; if we could unblock the process it would have a chance of evolving into something reasonable...

pat commented 11 years ago

@mloughran I appreciate the offer, but I have enough open source projects to maintain as it is :)

rkh commented 11 years ago

@mloughran as long as things get merged I don't need/want a commit bit. As to fixing the situation, I have been thinking about working on a major restructuring, but have not yet found the time.

mloughran commented 11 years ago

@pat don't we all ;) I'm trying to avoid making myself a blocker on the process. How about we go for a +1 to merge policy, and for now I'll just merge anything that gets at least one +1?

mloughran commented 11 years ago

Righto, I cherry picked this change as 576df84707f128b4575aeb6a4cd734dc1b95c829, and updated the certificate file which may fix you problems without having to override 796c9f7c5c851326a7634d64e29b3881c926ffa3