search

pusher-community / pusher-whos-in-gem

MIT License
22 stars 8 forks source link

local_scanner.sh assumes 192.168.1.0 network subnet #1

Closed brjpeters closed 9 years ago

brjpeters commented 9 years ago

The local_scanner.sh script always assumes the 192.168.1.0 network subnet is what needs to be scanned. This is going to be incorrect for a large majority of the people who want to use this gem. I went in and updated the bin script once the gem was installed, but not everyone will know to do that.

What should happen instead is that the subnet should probably just be another argument that is sent to the local_scanner shell script and should be determined when init is run. The init method could probably get a list of network interfaces on the machine and allow the user to select one.

brjpeters commented 9 years ago

I just looked at the code and it looks like init never actually saves anything anywhere. You'd probably want to add it as an argument to the run method.