Localhost 'NWWebSocketServer' for unit tests

pusher / NWWebSocket

A WebSocket client written in Swift, using the Network framework from Apple.

MIT License

123 stars 25 forks source link

Localhost 'NWWebSocketServer' for unit tests #11

Closed danielrbrowne closed 3 years ago

danielrbrowne commented 3 years ago

This PR resolves #9

Adds NWWebSocketServer (a localhost WebSocket echo server), as an internal class to use in 'NWWebSocketTests' in place of the externally-hosted server that was used previously.
- This is defined as internal for now. This may change in the future if there are requests to expose it as part of the public API.

danielrbrowne commented 3 years ago

Looks good. I wonder if the current implementation of NWSwiftWebSocketServer belongs in Tests rather than Sources because it's an "echo" server specifically designed for use in the tests, rather than being a generic server implementation.

That's a fair point, I'll push a change. This can always be moved back to Sources if we ever decide to expose it as part of the public API.