search

pusher / android-slack-clone

Android chat application, built with Chatkit
MIT License
10 stars 6 forks source link

Continuous authorization #1

Closed KingIdee closed 6 years ago

KingIdee commented 6 years ago

I think you should review how the authorization is done. It keeps redirecting me to the GitHub authorization page even after I just got authorized. I tried on two devices. As a result, I cant go past the entry activity. Did this happen to you too?

pablisco commented 6 years ago

Should be fixed by this commit: https://github.com/pusher/android-slack-clone/commit/58f48e909db18e497decc18364af0bc103d5d550

KingIdee commented 6 years ago

Surprisingly, it didn't. I noticed there were multiple calls made to the onNewIntent function. That should be as a result of the launchMode used.

pablisco commented 6 years ago

Did you try uninstalling the app and revoking access to the app on github (only if there is one present on your account)?

pablisco commented 6 years ago

@KingIdee Ok, it should be working again (not very elegantly though)

KingIdee commented 6 years ago

Still not working on my end. Where you able to reproduce the error? I uninstalled the app, revoked Chatkit's access and I'm still experiencing it. Let me try to fix it at my end and make a PR

KingIdee commented 6 years ago

Is the authentication smooth at your end? Please explain how the auth is supposed to flow. I can see a customized Chatkit and GitHub URL. I think this will help in providing a possible fix.

TobiAlbert commented 5 years ago

I'm still facing this issue, on my end.