pusher / atom-pair

An Atom package that allows for epic pair programming
MIT License
1.45k stars 28 forks source link

Deprecated selector in `atom-pair\styles\atom_pair.less` #113

Closed marquebr closed 7 years ago

marquebr commented 7 years ago

In atom-pair\styles\atom_pair.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

danielperez9430 commented 7 years ago

the same error

MrFiregore commented 7 years ago

remove all ::shadow and reopen atom

Aetherall commented 7 years ago

@firegore2 Where do I may remove ::shadow? Thx

ghost commented 7 years ago

Due to the inactivity of the repository collaborators regarding this fix, many atom-pair users have uninstalled this package and switched to a well-maintained version atom-pair-less which runs the same, but without persistent deprecations.

jayjun commented 7 years ago

Hi @jpatel531, @hot-leaf-juice, @Grot4x and @ewmy. Can we fix this?

leesio commented 7 years ago

Fix merged into master (3abdc4739ae6adb29d59b3543896ba7fdc9d093f) Tagged as release v2.0.12 and published to apm

Thanks to @Grot4x for the PR