search

pusher / atom-pair

An Atom package that allows for epic pair programming
MIT License
1.45k stars 28 forks source link

Object.add is deprecated. #45

Closed diakopter closed 9 years ago

diakopter commented 9 years ago

Are you trying to listen for the 'core:cancel' Atom command with jQuery::on? jQuery::trigger can no longer be used to listen for Atom commands. Please use atom.commands.add instead. See the docs at https://atom.io/docs/api/latest/CommandRegistry

jpatel531 commented 9 years ago

Thanks for bringing this to my attention! I'll have a look at it later today

jpatel531 commented 9 years ago

Just to double-check, is this what you're referring to: https://atom.io/docs/v0.186.0/upgrading/upgrading-your-package#dispatching-commands ? It looks like they have been deprecated for 'atom-workspace' and 'atom-text-editor', but I am unsure about whether they apply to instances of atom-space-pen views, which is where the package listens for core:cancel. Am I missing something extra?

diakopter commented 9 years ago

I dunno.. It was an auto-generated error/report. On May 26, 2015 4:59 PM, "Jamie Patel" notifications@github.com wrote:

Just to double-check, is this what you're referring to: https://atom.io/docs/v0.186.0/upgrading/upgrading-your-package#dispatching-commands ? It looks like they have been deprecated for 'atom-workspace' and 'atom-text-editor', but I am unsure about whether they apply to instances of atom-space-pen views, which is where the package listens for core:cancel. Am I missing something extra?

— Reply to this email directly or view it on GitHub https://github.com/pusher/atom-pair/issues/45#issuecomment-105663169.

jpatel531 commented 9 years ago

Version 1.1.6 has been released, which replaces these deprecated calls :)