search

pusher / atom-pair

An Atom package that allows for epic pair programming
MIT License
1.45k stars 28 forks source link

Uncaught TypeError: Cannot read property 'getText' of undefined #62

Closed lefte closed 7 years ago

lefte commented 9 years ago

[Enter steps to reproduce below:]

  1. ...the other dev waited quite a while to accept the invite, maybe it timed out?
  2. ...???
  3. Profit!

Atom Version: 1.0.4 System: Mac OS X 10.10.4 Thrown From: atom-pair package, v2.0.3

Stack Trace

Uncaught TypeError: Cannot read property 'getText' of undefined

At /Users/ehanson/.atom/packages/atom-pair/lib/modules/share_pane.coffee:164

TypeError: Cannot read property 'getText' of undefined
  at SharePane.module.exports.SharePane.shareFile (/Users/ehanson/.atom/packages/atom-pair/lib/modules/share_pane.coffee:164:26)
  at /Users/ehanson/.atom/packages/atom-pair/lib/atom_pair.coffee:175:7
  at PresenceChannel.prototype.emit (/Users/ehanson/.atom/packages/atom-pair/lib/pusher/pusher.js:855:17)
  at PresenceChannel.prototype.handleEvent (/Users/ehanson/.atom/packages/atom-pair/lib/pusher/pusher.js:3713:6)
  at PresenceChannel.prototype.handleEvent (/Users/ehanson/.atom/packages/atom-pair/lib/pusher/pusher.js:3831:51)
  at /Users/ehanson/.atom/packages/atom-pair/lib/pusher/pusher.js:74:9
  at ConnectionManager.prototype.emit (/Users/ehanson/.atom/packages/atom-pair/lib/pusher/pusher.js:855:17)
  at message (/Users/ehanson/.atom/packages/atom-pair/lib/pusher/pusher.js:3420:6)
  at Connection.prototype.emit (/Users/ehanson/.atom/packages/atom-pair/lib/pusher/pusher.js:855:17)
  at listeners.message (/Users/ehanson/.atom/packages/atom-pair/lib/pusher/pusher.js:3048:8)
  at TransportConnection.prototype.emit (/Users/ehanson/.atom/packages/atom-pair/lib/pusher/pusher.js:855:17)
  at TransportConnection.prototype.onMessage (/Users/ehanson/.atom/packages/atom-pair/lib/pusher/pusher.js:2210:6)
  at WebSocket.self.socket.onmessage (/Users/ehanson/.atom/packages/atom-pair/lib/pusher/pusher.js:2232:6)

Commands

Config

{
  "core": {},
  "atom-pair": {
    "pusher_app_key": "foo",
    "pusher_app_secret": "bar",
    "hipchat_room_name": "Hipchat (awyeah)",
    "hipchat_token": "nope"
  }
}

Installed Packages

# User
atom-pair, v2.0.3
auto-indent, v0.5.0
minimap, v4.12.2

# Dev
No dev packages
lefte commented 9 years ago

Possibly could also have been caused by "untitled" files open?

jpatel531 commented 9 years ago

Hmm I imagine it's related to #58 -- were there files open when your partner joined? I'm gonna tackle this tonight, and I think this might be a starting point

lefte commented 9 years ago

@jpatel531 yes, I had files open in tabs (including a couple of untitled/unsaved ones), as did the other side, so that might a good place to start looking. Thanks, great add-on, we foresee a LOT of useful scenarios already!

jpatel531 commented 9 years ago

Hey there - I've just published 2.0.5 - let me know how this addresses the problem :)