Why git checkout tags/template?

pusher / build-a-slack-clone-with-react-and-pusher-chatkit

In this tutorial, you'll learn how to build a chat app with React, complete with typing indicators, online status, and more.

https://pusher.com/chatkit

235 stars 68 forks source link

Why git checkout tags/template? #3

Closed lukejacksonn closed 6 years ago

lukejacksonn commented 6 years ago

How come you chose this approach? It puts you in an usual git place. I don't believe many people will have used this before too much. Could we get away without?

bookercodes commented 6 years ago

Yeah, this is a great point.

Possible solutions:

Move starter template to a separate repository. git clone only
Find a way to checkout without being in "detached HEAD" state

Thoughts?

lukejacksonn commented 6 years ago

Option A; alternatively have you considered create-react-app?

bookercodes commented 6 years ago

Yeah, I started the tutorial with create-react-app but I wanted to remove all the PWA and testing-related code. I also wanted to add a minimal server (with all the boilerplate stuff like body-parser) pre-installed.

lukejacksonn commented 6 years ago

Yeh, I know what you mean regard the PWA stuff.. so this is a personalised CRA by the looks of things. Humm 🤔 I would probably leave it as is but make the tags/template branch the master so that people don't have to do the checkout and can just commit on top of master like usual.

lukejacksonn commented 6 years ago

A complete branch has been pushed up.. but I am not sure that master is actually inline with the starter template. Will check again.

bookercodes commented 6 years ago

All sorted