search

pusher / chatkit-android

Android client SDK for Pusher Chatkit
https://pusher.com/chatkit
MIT License
53 stars 14 forks source link

SDK version value should reflect the version of the SDK, not the version of the app #129

Open zmarkan opened 5 years ago

zmarkan commented 5 years ago

Right now, it's taking whatever version the app is taking (see below link). It should instead take the version of the Chatkit SDK from the file releases.

https://github.com/pusher/chatkit-android/blob/dc42f8ea3bd9c877b21acf0ad9a9bd9d4a79f9bb/chatkit-android/src/main/kotlin/com/pusher/chatkit/AndroidChatkitDependencies.kt#L29

zmarkan commented 5 years ago

Actually, it might refer to the version here: https://github.com/pusher/chatkit-android/blob/master/chatkit-android/build.gradle#L19

It's possible to move the version assignment into an external variable and increment it there for both bintray version as well as for the buildConfig version.

daniellevass commented 4 years ago

We're looking at updating this process for v2 - watch this space 🙂