search

pusher / chatkit-client-js

JavaScript client SDK for Pusher Chatkit
https://pusher.com/chatkit
MIT License
90 stars 15 forks source link

Can you add babel env preset in esm build ? #210

Closed bogdand92 closed 4 years ago

bogdand92 commented 5 years ago

Hi guys, We using webpack and uglify-js and we can’t build our app after upgrading from 1.4.0 to 1.13.0, because of version 1.13.0 is no longer compatible with es5. In order to use uglify-js all our dependencies must be es5 compatible.

We found a commit which break es5 support: commit Rollup build of @pusher/push-notifications-web was splitted into separate esm and cdn, and esm version is not using babel-preset-env anymore.
Can you bring back es5 support to @pusher/chatkit-client?

uglify-js for 1.6.1 version and 1.13.1 video

Thanks for watching

bogdand92 commented 5 years ago
Screenshot 2019-09-26 at 16 15 51
callum-oakley commented 5 years ago

thanks a lot for this @bogdand92 . we'll take a look asap.

callum-oakley commented 4 years ago

fixed in 1.13.4 (apologies for the delay, this one got lost somewhere along the way...)