pusher / docs

The all new Pusher docs, powered by @11ty and @vercel
https://pusher.com/docs
8 stars 15 forks source link

Publish payloadspage #43

Closed fromi closed 3 years ago

fromi commented 3 years ago

Hello there, I spotted an issue on https://pusher.com/docs/beams/reference/publish-payloads/

The documentation provides this example: hide_notification_if_site_has_focus: true However, the Typescript typing of the project expects a string, not a boolean. I use the latest version: "@pusher/push-notifications-server": "^1.2.3"

fromi commented 3 years ago

After running some tests, it is a typescript typing issue and I had to do that do get the feature working: hide_notification_if_site_has_focus: (true as unknown as string)

benw-pusher commented 3 years ago

Hey, this sounds like an issue with the push notifications library rather than our docs - could you raise an issue there?