pusher / faros

Faros is a CRD based GitOps controller
Apache License 2.0
99 stars 15 forks source link

Add GitTrackInterface to API and Controller #151

Closed JoelSpeed closed 5 years ago

JoelSpeed commented 5 years ago

Like in the GitTrackObject controller, we use an interface for all interactions so that multiple underlying objects (GitTrackObject, ClusterGitTrackObject) can be used within the same controller.

We need to add an interface for the GitTrack controller as well, after which we will be able to implement a ClusterGitTrack and re-use the controller.

There is already an example of what the interface should look like here https://github.com/pusher/faros/pull/145/files#diff-1f12936b04e7511a7df782666a2238f1R25-R39, if possible please cherry-pick this interface so maintain attribution.