To implement the proposal in #150 we need to add a new CRD, this will implement the interface in #151.
We can add the new type to the existing API group (v1alpha1) and it will look pretty much identical to GitTrack apart from that it will be cluster scoped instead of namespace scoped.
We will also need to update the DeployKey struct to allow a namespace to be set for the ClusterGitTrack deploy credentials secret. We will also need to ensure this isn't set (or is ignored) on the regular namespaced GitTrack however.
To implement the proposal in #150 we need to add a new CRD, this will implement the interface in #151.
We can add the new type to the existing API group (
v1alpha1) and it will look pretty much identical toGitTrackapart from that it will be cluster scoped instead of namespace scoped.We will also need to update the DeployKey struct to allow a namespace to be set for the
ClusterGitTrackdeploy credentials secret. We will also need to ensure this isn't set (or is ignored) on the regular namespacedGitTrackhowever.This has already been partially done (though in a new API group which we don't want to do) in https://github.com/pusher/faros/pull/145/files#diff-05cef440b60e3505c0bb84bb0e025a51R30-R45. If possible, please try to retain some commit attribution for this work.