search

pusher / faros

Faros is a CRD based GitOps controller
Apache License 2.0
99 stars 15 forks source link

Tests for files-related functions #172

Closed mthssdrbrg closed 5 years ago

mthssdrbrg commented 5 years ago

This PR ports most of the old files-related tests to the new format (and are now done for ClusterGitTracks as well). There are some that are still pending being written, but the bulk is there.

I was planning on porting this bunch as well (the ones for invalid files are actually already included as of right now), although it won't really be the same as before as we're not testing the Status in the new handler suite, but I assume that this is intentional (cc @JoelSpeed)?

There's potentially still some cleaning up to do, but should be in a reviewable state.

mthssdrbrg commented 5 years ago

LGTM. Will the pending tests be fixed in a follow up PR or are we leaving those for now?

If I find the time later today I'll have a look at a follow up PR, but I don't think fixing them are a priority right now (as we haven't had tests for the previously).