pusher / k8s-spot-rescheduler

Tries to move K8s Pods from on-demand to spot instances
Apache License 2.0
311 stars 42 forks source link

There is no such --namespace=kube-system parameter #41

Closed duckty closed 6 years ago

duckty commented 6 years ago

Hello,

I ran your /bin/rescheduler command from the docker. There is no such --namespace param. But it is mentioned in https://github.com/pusher/k8s-spot-rescheduler/blob/master/deploy/deployment.yaml

docker run -it --rm quay.io/pusher/k8s-spot-rescheduler:v0.1.0 --help
Usage of rescheduler: rescheduler --running-in-cluster=true:
      --alsologtostderr                     log to standard error as well as files
      --housekeeping-interval duration      How often rescheduler takes actions. (default 10s)
      --kube-api-content-type string        Content type of requests sent to apiserver. (default "application/vnd.kubernetes.protobuf")
      --listen-address string               Address to listen on for serving prometheus metrics (default "localhost:9235")
      --log_backtrace_at traceLocation      when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                      If non-empty, write log files in this directory
      --logtostderr                         log to standard error instead of files (default true)
      --max-graceful-termination duration   How long should the rescheduler wait for pods to shutdown gracefully before
         failing the node drain attempt. (default 2m0s)
      --min-replica-count int               Minimum number or replicas that a replica set or replication controller should have to allow their pods deletion in scale down
      --node-drain-delay duration           How long the scheduler should wait between draining nodes. (default 10m0s)
      --on-demand-node-label string         Name of label on nodes to be considered for draining. (default "node-role.kubernetes.io/worker")
      --pod-eviction-timeout duration       How long should the rescheduler attempt to retrieve successful pod
         evictions for. (default 2m0s)
      --running-in-cluster                  Optional, if this controller is running in a kubernetes cluster, use the
         pod secrets for creating a Kubernetes client. (default true)
      --skip-nodes-with-local-storage       If true cluster autoscaler will never delete nodes with pods with local storage, e.g. EmptyDir or HostPath (default true)
      --skip-nodes-with-system-pods         If true cluster autoscaler will never delete nodes with pods from kube-system (except for DaemonSet or mirror pods) (default true)
      --spot-node-label string              Name of label on nodes to be considered as targets for pods. (default "node-role.kubernetes.io/spot-worker")
      --stderrthreshold severity            logs at or above this threshold go to stderr (default 2)
  -v, --v Level                             log level for V logs
      --vmodule moduleSpec                  comma-separated list of pattern=N settings for file-filtered logging
JoelSpeed commented 6 years ago

@duckty Apologies, theres a typo in the creation of the namespace flag. I've opened a PR to fix it and will make a 0.1.1 release for you

duckty commented 6 years ago

Thanks !