search

pusher / libPusher

An Objective-C interface to Pusher Channels
https://pusher.com/channels
Other
407 stars 130 forks source link

Remove unused docstring parameter #255

Closed keith closed 7 years ago

keith commented 7 years ago

This removes the outdated delegate function parameter, and enables the Xcode setting for warning about incorrect docstrings.

keith commented 7 years ago

Looks like the test failures here are unrelated to my changes.

hamchapman commented 7 years ago

Indeed, I've not looked properly yet (on my phone) but it's likely because of the secret env vars on Travis. I'll give it a bump / fix when I'm next with my laptop 👍

On 14 Apr 2017, 17:47 +0100, Keith Smiley notifications@github.com, wrote:

Looks like the test failures here are unrelated to my changes.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (https://github.com/pusher/libPusher/pull/255#issuecomment-294188863), or mute the thread (https://github.com/notifications/unsubscribe-auth/ACXEjqHu2WUkZHU1E2EynBVa0kwq5tLgks5rv6MVgaJpZM4M9geW).

hamchapman commented 7 years ago

Changed some things around on Travis so let's see if it works now

keith commented 7 years ago

Looks like it! Thanks!

keith commented 7 years ago

Thanks!