search

pusher / push-notifications-android

Android SDK for Pusher Beams
https://www.pusher.com/beams
MIT License
21 stars 21 forks source link

Migration to AndroidX #118

Closed deeborania closed 3 years ago

deeborania commented 3 years ago

This PR is to migrate to AndroidX which is the new way for feature parity acroos Android versions. I used Migrate to AndroidX... feature of the Android Studio and resolved few of the issues that cropped up.

julioromano commented 3 years ago

Hello @deeborania, Thanks for sending this alpha version out for testing. It seems to work fine.

But unfortunately, even after the androidx migration, version 1.7.0-alpha still transitively depends on some legacy support libraries and therefore any build of an Android application with android.enableJetifier=false will fail when importing this library.

This is due to the explicit dependency on com.firebase:firebase-jobdispatcher:0.8.5 which has been deprecated in April 2019 and archived 1 year after (see https://github.com/googlearchive/firebase-jobdispatcher-android ).

I'm afraid that will also need to be replaced somehow in order to make this library "truly" androidx compatible.