pusher / push-notifications-node

Pusher Beams Node.js Server SDK
https://pusher.com/beams
MIT License
20 stars 23 forks source link

Typescript support for PublishRequest of web type #42

Closed iamsiddhant05 closed 4 years ago

iamsiddhant05 commented 4 years ago

I was going through the typescript definitions and cannot find PublishRequest for web, it only has for APN and FCM ?

type PublishRequest =
  | PublishRequestWithApns
  | PublishRequestWithFcm
  | PublishRequestWithApnsAndFcm;

Can you add it or i could open a PR, but i need to know how much time will it be before you release?

jonathanlloyd commented 4 years ago

Thanks for raising this! I've got a PR open & will have a release out asap

jonathanlloyd commented 4 years ago

@iamsiddhant05 The fix for this is available in v1.2.1