search

pusher / push-notifications-ruby

Pusher Beams Ruby Server SDK
https://www.pusher.com/beams
MIT License
18 stars 9 forks source link

Endpoint using http #15

Closed luismfonseca closed 4 years ago

luismfonseca commented 4 years ago

This makes it consistent with https://github.com/pusher/push-notifications-node/blob/dca3bb891b5cd7ee13001a1e639e2c14e4cf57de/push-notifications.js#L39-L42, even though I'd maybe opt for a "base url override" that included the scheme.

codecov-commenter commented 4 years ago

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          262       277   +15     
=========================================
+ Hits           262       277   +15
Impacted Files Coverage Δ
spec/pusher/push_notifications/client_spec.rb 100.00% <100.00%> (ø)
...ec/pusher/push_notifications/configuration_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcf801a...04a1dd6. Read the comment docs.